ESP8266 Community Forum

- Tue Jul 28, 2015 11:35 pm #24499 I have been studying the code quite hard and would like to offer some contributions to the code. Is there a process I should follow?

I am new to contributing back to open source projects so if there is a recipe that I should follow to offer a change, please let me know.

Neil

Free ESP8266 book available for download here.

- Wed Jul 29, 2015 2:40 am #24506 Sure, patches are always appreciated! You can either mail or post a diff between your sources and the original (latest!) version of esphttpd, or you can clone the project on Github and make a pull request. (See eg https://help.github.com/articles/using-pull-requests/ for how to do that.)

Also, you may want to tell here what your modifications do - I try to keep the esphttpd sources as flexible and clean, so I may not accept all patches.

- Wed Jul 29, 2015 9:01 am #24546 Thank you sir ...
Not sure if you want a separate thread for each suggestions but I'll assume that all posts to this forum will be fine.

I have two notions. The first is on the mkespfsimage ... I want to have a build-time option that provides an alternative to mmap() which uses malloc and read to load the file into memory. As I build on Windows, I find that my libraries don't contain mmap but a build time option to use malloc, read and then free will mean that I don't need to mmap the files to be built. It is that feature that I would like to add but leave the default to be mmap.

The second notion is a version of mkespfsimage written in Java. That way it will just "run" on Windows, Linux, and OSX.

Neil

Free ESP8266 book available for download here.

- Wed Jul 29, 2015 8:50 pm #24591

Thank you sir ...
Not sure if you want a separate thread for each suggestions but I'll assume that all posts to this forum will be fine.

Nah, posting it here is fine.

I have two notions. The first is on the mkespfsimage ... I want to have a build-time option that provides an alternative to mmap() which uses malloc and read to load the file into memory. As I build on Windows, I find that my libraries don't contain mmap but a build time option to use malloc, read and then free will mean that I don't need to mmap the files to be built. It is that feature that I would like to add but leave the default to be mmap.

Fair enough, that sounds like a useful addition.

The second notion is a version of mkespfsimage written in Java. That way it will just "run" on Windows, Linux, and OSX.

And that's something that I'm probably not going to accept. It makes esphttpd depend on the Java runtime, which is less likely to be installed on the machine of a generic embedded developer than a C compiler, and I'm not going to want to maintain two versions of the same code. Maybe offering an automatically-built, precompiled version of the mkespfs executable is more useful for Windows users.