Markus Gritsch wrote:@zeroday: I am compiling on Windows. When the repository is checked out into a folder which has a space somewhere in it's path, launching esptool.py gives an error.
Please change in the Makefile
ESPTOOL = ../tools/esptool.py
to
ESPTOOL = python '../tools/esptool.py'
to fix this problem. Thanks, and keep up the good work!
you can change the Makefile yourself, or stop using spaces in paths (silly idea for everything!)
by adding the python bit you are ignoring the shebang in esptool.py and forcing the use of the system python rather than the one configured by virtualenv.
plus you're moving away from how the upstream esptool works.
this should absolutely not get put into nodemcu-firmware